Open
Conversation
jazzz
approved these changes
Feb 2, 2026
Collaborator
jazzz
left a comment
jazzz
left a comment
There was a problem hiding this comment.
This contribution is much appreciated. Appreciate you helping out!
kaichaosun
reviewed
Feb 3, 2026
.github/workflows/ci.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: [ main, master, develop ] |
Contributor
There was a problem hiding this comment.
Can you remove master and develop branch here? We don't have such branches for working.
Also for the pull_request section.
| strategy: | ||
| matrix: | ||
| toolchain: | ||
| - stable |
Contributor
There was a problem hiding this comment.
We probably only want to focus on the stable release, right? @jazzz
Restrict CI workflow to only the main branch for pushes and pull requests.
kaichaosun
approved these changes
Feb 3, 2026
osmaczko
approved these changes
Feb 3, 2026
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: rustup update stable && rustup default stable |
There was a problem hiding this comment.
Suggested change
| - run: rustup update stable && rustup default stable | |
| - run: rustup update ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }} |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: rustup update stable && rustup default stable |
There was a problem hiding this comment.
Suggested change
| - run: rustup update stable && rustup default stable | |
| - run: rustup update ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #38 by providing basic ci with 3 basic jobs, mainly test, clippy and format jobs.